From 482d2676a1abad0a64bc525d6f060fb7e547701d Mon Sep 17 00:00:00 2001
From: Tom Smeding <tom@tomsmeding.com>
Date: Tue, 11 Feb 2025 22:49:30 +0100
Subject: statusbot: Better error messages

---
 modules/statusbot/statusbot.js | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/modules/statusbot/statusbot.js b/modules/statusbot/statusbot.js
index 665bfeb..94894a9 100644
--- a/modules/statusbot/statusbot.js
+++ b/modules/statusbot/statusbot.js
@@ -258,25 +258,25 @@ function matrixSendMsgLogin(text, cb) {
       case 401:
         matrixLogin((success, body) => {
           if (!success) {
-            logFailure(`Failed to log in: ${body}`, () => cb(false));
+            logFailure(`Failed to log in, error: ${body}`, () => cb(false));
             return;
           }
 
           matrixSendMsg(text, (status, body) => {
             switch (status) {
               case 200: cb(true); return;
-              case 401: logFailure(`401 even after login: ${body}`, () => cb(false)); break;
-              default: logFailure(`Failed to send message: ${body}`, () => cb(false)); break;
+              case 401: logFailure(`401 even after login, error: ${body}`, () => cb(false)); break;
+              default: logFailure(`Failed to send message, error: ${body}`, () => cb(false)); break;
             }
           });
         });
         break;
 
       default:
-        logFailure(`Failed to send message: ${body}`, () => cb(false));
+        logFailure(`Failed to send message, error: ${body}`, () => cb(false));
         break;
     }
-  })
+  });
 }
 
 module.exports = function(app, io, _moddir) {
@@ -307,8 +307,10 @@ module.exports = function(app, io, _moddir) {
             if (!finished) {
               res.sendStatus(504);  // gateway timeout
               logFailure(`Timed out on message: [${req.body.sender}] ${req.body.text}`, () => {});
-            } else if (!success) res.sendStatus(503);  // service unavailable
-            else res.sendStatus(200);
+            } else if (!success) {
+              res.sendStatus(503);  // service unavailable
+              logFailure(`Unsuccessful for message: [${req.body.sender}] ${req.body.text}`, () => {});
+            } else res.sendStatus(200);
             rlcb();
           }
         );
-- 
cgit v1.2.3-70-g09d2